Skip to content

feat: add blas/base/csrot #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 14, 2024
Merged

feat: add blas/base/csrot #2256

merged 16 commits into from
Jul 14, 2024

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to apply a plane rotation, where the cos and sin (c and s) are real and the vectors cx and cy are single-precision floating-point vectors as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/csrot is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 21, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label May 23, 2024
@kgryte kgryte mentioned this pull request Jul 10, 2024
Merged
1 task
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 10, 2024
@kgryte
Copy link
Member

kgryte commented Jul 10, 2024

I suggest doing a line-by-line port of the changes made in #2257.

kgryte
kgryte reviewed Jul 10, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 10, 2024
View reviewed changes
@aman-095
Copy link
Member Author

Hey, @kgryte, I have applied the changes based on #2257.

@aman-095 aman-095 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 11, 2024
kgryte
kgryte approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 14, 2024
@kgryte
Copy link
Member

kgryte commented Jul 14, 2024

@aman-095 Would you mind always cross-referencing to the tracking issue in the OP of your PRs? This will help me during review and merge when cross-linking commits to the tracking issue.

@kgryte kgryte merged commit bdaa7e0 into stdlib-js:develop Jul 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-095 @kgryte @Planeshifter @stdlib-bot